On Thu, 17 Dec 2015 19:08:46 +0300 Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote: > On Mon, Sep 14, 2015 at 12:24 PM, Martin Schwidefsky > <schwidefsky@xxxxxxxxxx> wrote: > > Fixes a regression introduced with commit 179ef71cbc085252 > > "mm: save soft-dirty bits on swapped pages" > > > > The maybe_same_pte() function is used to match a swap pte independent > > of the swap software dirty bit set with pte_swp_mksoft_dirty(). > > > > For CONFIG_HAVE_ARCH_SOFT_DIRTY=y but CONFIG_MEM_SOFT_DIRTY=n the > > software dirty bit may be set but maybe_same_pte() will not recognize > > a software dirty swap pte. Due to this a 'swapoff -a' will hang. > > > > The straightforward solution is to replace CONFIG_MEM_SOFT_DIRTY > > with HAVE_ARCH_SOFT_DIRTY in maybe_same_pte(). > > > > Cc: linux-mm@xxxxxxxxx > > Cc: Cyrill Gorcunov <gorcunov@xxxxxxxxx> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Cc: Michal Hocko <mhocko@xxxxxxx> > > Reported-by: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx> > > Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > > We've been discussing this already > http://comments.gmane.org/gmane.linux.kernel.mm/138664 Yes indeed. I'm still trying to find out how this mail has been sent a second time. That was not intentional, sorry for the noise. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>