On Wed, 2015-12-16 at 19:17 +0100, Borislav Petkov wrote:
> On Wed, Dec 16, 2015 at 09:52:37AM -0800, Dan Williams wrote:
> > It's possible that as far as the resource table is concerned the
> > resource type might just be "reserved". It may not be until after a
> > driver loads that we discover the memory range type. The identifying
> > string is driver specific at that point.
>
> So how many types are we talking about here? Because I don't find a whole
> lot:
>
> $ git grep -E "(walk_iomem_res|find_next_iomem_res|region_intersects)" --
> *.c | grep -Eo '\".*\"'
> "GART"
> "ACPI Tables"
> "ACPI Non-volatile Storage"
> "Crash kernel"
> "System RAM"
> "System RAM"
> "System RAM"
>
> An int type could contain 2^32 different types.
In this approach, as I understand, we add a new field to 'struct resource',
i.e. 'type' in this example.
struct resource crashk_res = {
.name = "Crash kernel",
.start = 0,
.end = 0,
.flags = IORESOURCE_BUSY | IORESOURCE_SYSTEM_RAM,
+ .type = RES_TYPE_CRASH_KERNEL,
};
And we change the callers, such as "kernel/kexec_file.c" to search with
this RES_TYPE.
ret = walk_iomem_res(RES_TYPE_CRASH_KERNEL,
IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY, ...);
We only change the resource entries that support the search interfaces to:
- Assign RES_TYPE_XXX.
- Initialize 'type' in its 'struct resource' with the type.
This avoids changing all drivers. When we have a new search for "foo", we
will then need to:
- Define RES_TYPE_FOO.
- Add '.type = RES_TYPE_FOO' to the code where it initializes the "foo"
entry.
This scheme may have a problem, though. For instance, when someone writes
a loadable module that searches for "foo", but the "foo" entry may be
initialized in a distro kernel/driver that cannot be modified. Since this
search is only necessary to obtain a range initialized by other module,
this scenario is likely to happen. We no longer have ability to search for
a new entry unless we modify the code that initializes the entry first.
> > All this to say that with strcmp we can search for any custom type .
> > Otherwise I think we're looking at updating the request_region()
> > interface to take a type parameter. That makes strcmp capability more
> > attractive compared to updating a potentially large number of
> > request_region() call sites.
>
> Right, but I don't think that @name param to request_region() was ever
> meant to be mis-used as a matching attribute when iterating over the
> resource types.
Even if we avoid strcmp() with @name in the kernel, user applications will
continue to use @name since that is the only type available in /proc/iomem.
For instance, kexec has its own search function with a string name.
https://github.com/Tasssadar/kexec-tools/blob/master/kexec/kexec-iomem.c
> Now, imagine you have to do this pretty often. Which is faster: a
> strcmp() or an int comparison...?
>
> Even if this cannot be changed easily/in one go, maybe we should at
> least think about starting doing it right so that the strcmp() "fun" is
> phased out gradually...
When a new commonly-used search name comes up, we can define it as a new
extended I/O resource type similar to IORESOURCE_SYSTEM_RAM. For the
current remaining cases, i.e. crash, kexec, and einj, they have no impact
to performance. Leaving these special cases aside will keep the ability to
search for any entry without changing the kernel, and save some memory
space from adding the new 'type'.
Thanks,
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>