On Wed 09-12-15 15:30:04, Johannes Weiner wrote: > Hey guys, > > there has been quite a bit of trouble that stems from dividing our > CONFIG space and having to provide real code and dummy functions > correctly in all possible combinations. This is amplified by having > the legacy mode and the cgroup2 mode in the same file sharing code. > > The socket memory and kmem accounting series is a nightmare in that > respect, and I'm still in the process of sorting it out. But no matter > what the outcome there is going to be, what do you think about getting > rid of the CONFIG_MEMCG[_LEGACY]_KMEM and CONFIG_INET stuff? The code size difference after your recent patches is indeed not that large but that is only because huge part of the kmem code is enabled by default now. I have raised this in the reply to the respective patch. This is ~8K of the code 1K for data. I do understand your reasoning about the complications but this is quite a lot of code. CONFIG_INET ifdefs are probably pointless - they do not add really much and most configs will have it by default. The core for KMEM seems to be a different thing to me. Maybe we can reorganize the code to make the maintenance easier and still allow to enable KMEM accounting separately for kernel size savy users? [...] -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>