On Mon, 2015-11-23 at 12:56 -0800, Dan Williams wrote: > On Mon, Nov 23, 2015 at 12:45 PM, Toshi Kani <toshi.kani@xxxxxxx> wrote: > > On Mon, 2015-11-23 at 12:45 -0800, Dan Williams wrote: > > > On Mon, Nov 23, 2015 at 12:05 PM, Toshi Kani <toshi.kani@xxxxxxx> wrote: > [..] > > > This is a nop if CONFIG_TRANSPARENT_HUGEPAGE=n, so I don't think it's > > > a complete fix. > > > > Well, __dax_pmd_fault() itself depends on CONFIG_TRANSPARENT_HUGEPAGE. > > > > Indeed it is... I think that's wrong because transparent huge pages > rely on struct page?? I do not think this issue is related with struct page. wp_huge_pmd() calls either do_huge_pmd_wp_page() or dax_pmd_fault(). do_huge_pmd_wp_page() splits a pmd page when it returns with VM_FAULT_FALLBACK. So, this change keeps them consistent on VM_FAULT_FALLBACK. Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>