Michal Hocko wrote:
> I haven't checked where exactly you added the BUG_ON, I was merely
> comenting on the possibility that TIF_MEMDIE is set without sending
> SIGKILL.
>
> Now that I am looking at your BUG_ON more closely I am wondering whether
> it makes sense at all. The fatal signal has been dequeued in get_signal
> before we call into do_group_exit AFAICS.
Indeed, it makes no sense at all.
Making below change made expected output.
MemAlloc: oom-tester4(11306) uninterruptible exiting victim
----------
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 01127b8..8c8fb6d 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3289,8 +3289,9 @@ static int kmallocwd(void *unused)
snprintf(buf, sizeof(buf),
" gfp=0x%x order=%u delay=%lu", memalloc.gfp,
memalloc.order, now - memalloc.start);
- pr_warn("MemAlloc: %s(%u)%s%s%s%s\n", p->comm, p->pid, buf,
+ pr_warn("MemAlloc: %s(%u)%s%s%s%s%s\n", p->comm, p->pid, buf,
(type & 8) ? " uninterruptible" : "",
+ (p->flags & PF_EXITING) ? " exiting" : "",
(type & 2) ? " dying" : "",
(type & 1) ? " victim" : "");
touch_nmi_watchdog();
----------
I'll make V3 of kmallocwd. Thank you.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>