On Wed, Nov 18, 2015 at 3:23 PM, Daniel Cashman <dcashman@xxxxxxxxxxx> wrote: >> I think the min/max values should be const, since they're determined >> at build time and should never change. > > Ok. Also, I just submitted the patch-set again with [PATCH v3] instead > of [PATCH] so I'd prefer discussion there; sorry for the mistake. Oops, yeah, just saw that come in after I already sent my comments. :P -Kees -- Kees Cook Chrome OS Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>