On Thu 12-11-15 12:47:45, David Rientjes wrote: > On Thu, 12 Nov 2015, mhocko@xxxxxxxxxx wrote: [...] > > Hi, > > I think that this is more a cleanup than any functional change. We > > are rarely screwed so much that __alloc_pages_high_priority would > > fail. Yet I think that __alloc_pages_high_priority is obscuring the > > overal intention more than it is helpful. Another motivation is to > > reduce wait_iff_congested call to a single one in the allocator. I plan > > to do other changes in that area and get rid of it altogether. > > I think it's a combination of a cleanup (the inlining of > __alloc_pages_high_priority) and a functional change (no longer looping > infinitely around a get_page_from_freelist() call). I'd suggest doing the > inlining in one patch and then the reworking of __GFP_NOFAIL when > ALLOC_NO_WATERMARKS fails just so we could easily revert the latter if > necessary. I can split it up if this is really preferable of course. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>