On Mon 09-11-15 21:28:40, Vladimir Davydov wrote: > On Mon, Nov 09, 2015 at 03:08:32PM +0100, Michal Hocko wrote: [...] > > > Vladimir Davydov (5): > > > Revert "kernfs: do not account ino_ida allocations to memcg" > > > Revert "gfp: add __GFP_NOACCOUNT" > > > > The patch ordering would break the bisectability. I would simply squash > > How's that? AFAICS the kernel should compile after any first N=1..5 > patches of the series applied. Sorry, forgot to comment on this. I didn't mean it would break compilation. It would just reintroduce the bug fixed by "kernfs: do not account ino_ida allocations to memcg". My understanding is that the bug is quite unlikely and it will results in a pinned memcg which is much less serious than a crash or other misbehavior. I will leave whether this is serious enough to you but as the revert is basically dropping the flag which can be trivially done in the patch which renames it and changes its semantic I do not think splitting has any large advantage. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>