On Mon, 9 Nov 2015 22:12:09 +0100 Jann Horn <jann@xxxxxxxxx> wrote: > > > Can we do > > > > #define PTRACE_foo (PTRACE_MODE_READ|PTRACE_MODE_FSCREDS) > > > > to avoid all that? > > Hm. All combinations of the PTRACE_MODE_*CREDS flags with > PTRACE_MODE_{READ,ATTACH} plus optionally PTRACE_MODE_NOAUDIT > make sense, I think. So your suggestion would be to create > four new #defines > PTRACE_MODE_{READ,ATTACH}_{FSCREDS,REALCREDS} and then let > callers OR in the PTRACE_MODE_NOAUDIT flag if needed? If these flag combinations have an identifiable concept behind them then sure, it makes sense to capture that via a well-chosen identifier. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>