On Thu 05-11-15 18:31:32, Andrew Morton wrote: > On Wed, 4 Nov 2015 10:18:04 +0100 Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > On Tue 03-11-15 15:32:11, Andrew Morton wrote: > > > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > Subject: memcg-fix-thresholds-for-32b-architectures-fix-fix > > > > > > don't attempt to inline mem_cgroup_usage() > > > > > > The compiler ignores the inline anwyay. And __always_inlining it adds 600 > > > bytes of goop to the .o file. > > > > I am not sure you whether you want to fold this into the original patch > > but I would prefer this to be a separate one. > > I'm going to drop this - it was already marked inline and gcc just > ignores the inline anyway so shrug. gcc version 5.2.1 20151010 (Debian 5.2.1-22) $ size mm/memcontrol.o mm/memcontrol.o.before text data bss dec hex filename 35535 7908 64 43507 a9f3 mm/memcontrol.o 35762 7908 64 43734 aad6 mm/memcontrol.o.before So it's only 227B but still. I think it is worth it. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>