Re: [PATCH v1] mm: hwpoison: adjust for new thp refcounting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 06, 2015 at 01:31:49AM -0500, Sasha Levin wrote:
> On 11/06/2015 01:11 AM, Naoya Horiguchi wrote:
> > In the new refcounting, we no longer use tail->_mapcount to keep tail's
> > refcount, and thereby we can simplify get_hwpoison_page() and remove
> > put_hwpoison_page() (by replacing with put_page()).
> 
> This is confusing for the reader (and some static analysis tools): this adds
> put_page()s without corresponding get_page()s.
> 
> Could we instead macro put_hwpoison_page() as put_page() for the sake of readability?

OK, I'll do this.

Thanks,
Naoya Horiguchi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]