On Fri, Oct 23, 2015 at 11:23:26AM +0800, Hillf Danton wrote: > > > > + if (cnt_hmm_entry) { > > > > + int ret; > > > > + > > > > + ret = hmm_mm_fork(src_mm, dst_mm, dst_vma, > > > > + dst_pmd, start, end); > > > > > > Given start, s/end/addr/, no? > > > > No, end is the right upper limit here. > > > Then in the first loop, hmm_mm_fork is invoked for > the _entire_ range, from input addr to end. > In subsequent loops(if necessary), start is updated to > addr, and hmm_mm_fork is also invoked for remaining > range, from start to end. > > Is the above overlap in range making sense? Well yes and no, hmm_mm_fork() will do nothing for address >= addr i feel like end is easier to understand. Cheers, Jérôme -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>