On 10/17/15 1:20 PM, Rasmus Villemoes wrote:
As far as I can tell, strncpy_from_unsafe never returns -EFAULT. ret is the result of a __copy_from_user_inatomic(), which is 0 for success and positive (in this case necessarily 1) for access error - it is never negative. So we were always returning the length of the, possibly truncated, destination string. Signed-off-by: Rasmus Villemoes<linux@xxxxxxxxxxxxxxxxxx> --- Probably not -stable-worthy. I can only find two callers, one of which ignores the return value.
good catch. Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx> cc-ing original authors where I copy pasted that part from. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>