On Fri, 16 Oct 2015 15:12:23 -0700 (PDT) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > > --- a/include/linux/memcontrol.h > > > +++ b/include/linux/memcontrol.h > > > @@ -26,6 +26,7 @@ > > > #include <linux/page_counter.h> > > > #include <linux/vmpressure.h> > > > #include <linux/eventfd.h> > > > +#include <linux/mm.h> > > > #include <linux/mmzone.h> > > > #include <linux/writeback.h> > > > > > Are you expecting to use mem_cgroup_from_kmem() from other places > in future? Seems possible; but at present it's called from only > one place, and (given how memcontrol.h has somehow managed to avoid > including mm.h all these years), I thought it would be nice to avoid > it for just this; Yes, I was wondering about that. I figured that anything which includes memcontrol.h is already including mm.h and gcc is pretty efficient with handling the #ifdef FOO_H_INCLUDED guards. > and fixed my build with the patch below last night. > Whatever you all think best: just wanted to point out an alternative. Yes, that's neater - let's go that way. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>