On Wed, Oct 14, 2015 at 11:03 AM, Christoph Lameter <cl@xxxxxxxxx> wrote:
> On Wed, 14 Oct 2015, Linus Torvalds wrote:
>>
>> So why is this a bugfix? If cpu == WORK_CPU_UNBOUND, then things
>> _shouldn't_ care which cpu it gets run on.
>
> UNBOUND means not fixed to a processor.
That's exactly what I'm saying.
And "schedule_delayed_work()" uses WORK_CPU_UNBOUND.
YOUR code assumes that means "local CPU".
And I say that's bogus.
In this email you seem to even agree that its' bogus, but then you
wrote another email saying that the code isn't confused, because it
uses "schedule_delayed_work()" on the CPU that it wants to run the
code on.
I'm saying that mm/vmstat.c should use "schedule_delayed_work_on()".
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>