On Mon, Oct 12, 2015 at 10:40:06AM +0800, yalin wang wrote: > Remove unlikely(order), because we are sure order is not zero if > code reach here, also add if (page == NULL), only allocate page again if > __rmqueue_smallest() failed or alloc_flags & ALLOC_HARDER == 0 > > Signed-off-by: yalin wang <yalin.wang2010@xxxxxxxxx> Thanks very much for catching this! Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> With your current subject and changelog, there is a small risk that Andrew will miss this or not see it for some time. Would you mind resending the patch with a changelog similar to this please? It spells out that it is a fix to an mmotm patch so it'll be obvious where it should be inserted before merging to mainline. From: yalin wang <yalin.wang2010@xxxxxxxxx> Subject: [PATCH] mm, page_alloc: reserve pageblocks for high-order atomic allocations on demand -fix There is a redundant check and a memory leak introduced by a patch in mmotm. This patch removes an unlikely(order) check as we are sure order is not zero at the time. It also checks if a page is already allocated to avoid a memory leak. This is a fix to the mmotm patch mm-page_alloc-reserve-pageblocks-for-high-order-atomic-allocations-on-demand.patch Signed-off-by: yalin wang <yalin.wang2010@xxxxxxxxx> Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>