On 10/10/2015 22:57, Dan Williams wrote: > On Sat, Oct 10, 2015 at 1:35 PM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: >> On 10/10/2015 02:56, Dan Williams wrote: >>> The core has developed a need for a "pfn_t" type [1]. Move the existing >>> pfn_t in KVM to kvm_pfn_t [2]. >>> >>> [1]: https://lists.01.org/pipermail/linux-nvdimm/2015-September/002199.html >>> [2]: https://lists.01.org/pipermail/linux-nvdimm/2015-September/002218.html >> >> Can you please change also the other types in include/linux/kvm_types.h? > > Hmm, all those seem kvm specific already. I'd only prefix them with > kvm_ if they collided with a "core" type. But they are all related and the code becomes uglier if you only prefix one of them. If you don't convert all of them, I will do it anyway as soon as this patch get in. Since it touches a lot of KVM files, we should synchronize in order to avoid conflicts and gnashing of teeth. What tree is this patch going in? You could provide me a commit SHA1 for this patch (well, its definitive version) based on Linus's tree (so that I can merge it in my tree as well), or I could commit it and provide the SHA1 to the maintainer of said tree. Paolo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>