On Friday 09 October 2015 03:23 PM, Kirill A. Shutemov wrote: > On Tue, Sep 22, 2015 at 04:04:53PM +0530, Vineet Gupta wrote: >> > - pgtable-generic.c: Fold individual #ifdef for each helper into a top >> > level #ifdef. Makes code more readable > Makes sense. > >> > - Per Andrew's suggestion removed the dummy implementations for !THP >> > in asm-generic/page-table.h to have build time failures vs. runtime. > I'm not sure it's a good idea. This can lead to unnecessary #ifdefs where > otherwise call to helper would be eliminated by compiler as dead code. > > What about dummy helpers with BUILD_BUG()? > You are right after all. It is not so much related to __HAVE_ARCH_PMDP_xyz, but the fact that generic code can call them under PageTransHuge(). So better to provide stubs with BUILD_BUG -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>