On Tue 06-10-15 12:22:25, Andrew Morton wrote: > On Tue, 6 Oct 2015 19:01:23 +0200 Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > On Mon 05-10-15 14:44:22, Shaohua Li wrote: > > > The page_counter_memparse() returns pages for the threshold, while > > > mem_cgroup_usage() returns bytes for memory usage. Convert the threshold > > > to bytes. > > > > > > Looks a regression introduced by 3e32cb2e0a12b69150 > > > > Yes. This suggests > > Cc: stable # 3.19+ > > But it's been this way for 2 years and nobody noticed it. How come? Maybe we do not have that many users of this API with newer kernels. > Or at least, nobody reported it. Maybe people *have* noticed it, and > adjusted their userspace appropriately. In which case this patch will > cause breakage. I dunno, I would rather have it fixed than keep bug to bug compatibility because they would eventually move to a newer kernel one day when they see the "breakage" anyway. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>