On Sun, Oct 04, 2015 at 07:04:06PM -0700, Davidlohr Bueso wrote: > On Sun, 04 Oct 2015, Leon Romanovsky wrote: > > >On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang <geliangtang@xxxxxxx> wrote: > >>BUG_ON() already contain an unlikely compiler flag. Drop it. > >It is not the case if CONFIG_BUG and HAVE_ARCH_BUG_ON are not set. > > Yeah, but that's like the 1% of the cases -- and those probably don't even care > about the branch prediction (I could be wrong). So overall I like getting rid of > explicit BUG_ON(unlikely(... calls. In fact there's a _reason_ why there are so > few of them in the kernel. I agree with you that this change is welcomed and I would like to see it is accepted. My main concern that I would expect to see it's coming after the change of BUG_ON definition to be similar in all places, with "unlikely" in all definitions, and not instead. > > Thanks, > Davidlohr -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>