Hi, > -----Original Message----- > From: Anshuman Khandual [mailto:khandual@xxxxxxxxxxxxxxxxxx] > Sent: Thursday, October 01, 2015 7:00 PM > To: Pintu Kumar; akpm@xxxxxxxxxxxxxxxxxxxx; minchan@xxxxxxxxxx; > dave@xxxxxxxxxxxx; mhocko@xxxxxxx; koct9i@xxxxxxxxx; rientjes@xxxxxxxxxx; > hannes@xxxxxxxxxxx; penguin-kernel@xxxxxxxxxxxxxxxxxxx; > bywxiaobai@xxxxxxx; mgorman@xxxxxxx; vbabka@xxxxxxx; js1304@xxxxxxxxx; > kirill.shutemov@xxxxxxxxxxxxxxx; alexander.h.duyck@xxxxxxxxxx; > sasha.levin@xxxxxxxxxx; cl@xxxxxxxxx; fengguang.wu@xxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx > Cc: cpgs@xxxxxxxxxxx; pintu_agarwal@xxxxxxxxx; pintu.ping@xxxxxxxxx; > vishnu.ps@xxxxxxxxxxx; rohit.kr@xxxxxxxxxxx; c.rajkumar@xxxxxxxxxxx; > sreenathd@xxxxxxxxxxx > Subject: Re: [PATCH 1/1] mm: vmstat: Add OOM kill count in vmstat counter > > On 10/01/2015 04:18 PM, Pintu Kumar wrote: > > This patch maintains number of oom calls and number of oom kill count > > in /proc/vmstat. > > It is helpful during sluggish, aging or long duration tests. > > Currently if the OOM happens, it can be only seen in kernel ring buffer. > > But during long duration tests, all the dmesg and /var/log/messages* > > could be overwritten. > > So, just like other counters, the oom can also be maintained in > > /proc/vmstat. > > It can be also seen if all logs are disabled in kernel. > > Makes sense. > > > > > A snapshot of the result of over night test is shown below: > > $ cat /proc/vmstat > > oom_stall 610 > > oom_kill_count 1763 > > > > Here, oom_stall indicates that there are 610 times, kernel entered > > into OOM cases. However, there were around 1763 oom killing happens. > > The OOM is bad for the any system. So, this counter can help the > > developer in tuning the memory requirement at least during initial bringup. > > Can you please fix the formatting of the commit message above ? > Not sure if there is any formatting issue here. I cannot see it. The checkpatch returns no error/warnings. Please point me out exactly, if there is any issue. > > > > Signed-off-by: Pintu Kumar <pintu.k@xxxxxxxxxxx> > > --- > > include/linux/vm_event_item.h | 2 ++ > > mm/oom_kill.c | 2 ++ > > mm/page_alloc.c | 2 +- > > mm/vmstat.c | 2 ++ > > 4 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/vm_event_item.h > > b/include/linux/vm_event_item.h index 2b1cef8..ade0851 100644 > > --- a/include/linux/vm_event_item.h > > +++ b/include/linux/vm_event_item.h > > @@ -57,6 +57,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, > > PSWPOUT, #ifdef CONFIG_HUGETLB_PAGE > > HTLB_BUDDY_PGALLOC, HTLB_BUDDY_PGALLOC_FAIL, #endif > > + OOM_STALL, > > + OOM_KILL_COUNT, > > Removing the COUNT will be better and in sync with others. Ok, even suggested by Michal Hocko and being discussed in another thread. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>