[PATCH 0/3] Revert locking changes in DAX for v4.3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This series reverts some recent changes to the locking scheme in DAX introduced
by these two commits:

commit 843172978bb9 ("dax: fix race between simultaneous faults")
commit 46c043ede471 ("mm: take i_mmap_lock in unmap_mapping_range() for DAX")

The list of issues in DAX after these commits (some newly introduced by the
commits, some preexisting) can be found here:
	    
https://lkml.org/lkml/2015/9/25/602

Several of these issues were preexisting, and are being addressed by moving the
locking in DAX to the filesystem.  A patch series doing this for XFS is here:

https://lkml.org/lkml/2015/10/1/180

These fixes will end up hitting v4.4, hopefully.

In the mean time the above two commits *did* introduce several deadlocks and a
null pointer issue.  I started fixing them one at a time:

https://lkml.org/lkml/2015/9/23/607
https://lkml.org/lkml/2015/9/22/668

But it soon became apparent that there were just too many corner cases.  The
current plan is to revert the locking in DAX to the old v4.2 scheme, and then
proceed with fixing the rest of the issues by moving the locking into the
various filesystems that support DAX.  Dave Chinner is working on this for XFS,
and Jan Kara has said he will help with ext4.

akpm, this series obviates my patch "dax: fix deadlock in __dax_fault()" that
is currently in the -mm tree but which I believe has not yet been sent to Linus.
Can you please just remove it from -mm?

Ross Zwisler (3):
  Revert "dax: fix NULL pointer in __dax_pmd_fault()"
  Revert "mm: take i_mmap_lock in unmap_mapping_range() for DAX"
  Revert "dax: fix race between simultaneous faults"

 fs/dax.c    | 83 +++++++++++++++++++++++++------------------------------------
 mm/memory.c |  2 ++
 2 files changed, 36 insertions(+), 49 deletions(-)

-- 
2.1.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]