Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise <00moses.alexander00@xxxxxxxxx> wrote:

> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> > >  
> > >  static unsigned long zone_reclaimable_pages(struct zone *zone)
> > >  {
> > > -	int nr;
> > > +	unsigned long nr;
> > >  
> > >  	nr = zone_page_state(zone, NR_ACTIVE_FILE) +
> > >  	     zone_page_state(zone, NR_INACTIVE_FILE);
> > 
> > OK.
> > 
> 
> Are you sure? Mel Gorman raised the following issue on patch 1/2:
> 
> https://lkml.org/lkml/2015/9/29/253

__zone_watermark_ok() is very different from zone_reclaimable_pages().

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]