On Wed, Sep 23, 2015 at 6:47 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Dan, > > On Wed, Sep 23, 2015 at 6:42 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote: >> Convert the raw unsigned long 'pfn' argument to __pfn_t for the purpose of >> evaluating the PFN_MAP and PFN_DEV flags. When both are set the it > > s/the it/it/ yes. >> triggers _PAGE_DEVMAP to be set in the resulting pte. This flag will >> later be used in the get_user_pages() path to pin the page mapping, >> dynamically allocated by devm_memremap_pages(), until all the resulting >> pages are released. >> >> There are no functional changes to the gpu drivers as a result of this >> conversion. >> >> This uncovered several architectures with no local definition for >> pfn_pte(), in response __pfn_t_pte() is only defined when an arch >> opts-in by "#define pfn_pte pfn_pte". >> >> Cc: Dave Hansen <dave@xxxxxxxx> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: David Airlie <airlied@xxxxxxxx> >> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> > >> diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h >> index ef209169579a..930a42f6db44 100644 >> --- a/arch/m68k/include/asm/page_no.h >> +++ b/arch/m68k/include/asm/page_no.h >> @@ -34,6 +34,7 @@ extern unsigned long memory_end; >> >> #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ >> ((void *)(kaddr) < (void *)memory_end)) >> +#define __pfn_to_phys(pfn) PFN_PHYS(pfn) > > The above change doesn't match the patch description? > I should have noted that this is a new compile error introduced by this patch since include/linux/mm.h now calls __pfn_to_phys() and m68k does not always have it defined. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>