On Mon, Sep 21, 2015 at 11:23 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> +
> + for_each_process(g) {
> + struct task_struct *p;
> + struct mm_struct *mm;
> pgd_t *pgd;
> spinlock_t *pgt_lock;
>
> + p = find_lock_task_mm(g);
> + if (!p)
> + continue;
> +
> + mm = p->mm;
So quite frankly, this is *much* better than the earlier version that
walked over all threads.
However, this now becomes a pattern for the series, and that just makes me think
"Why is this not a 'for_each_mm()' pattern helper?"
if it only showed up once, that would be one thing. But this
patch-series makes it a thing. Which is why I wonder..
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>