On Fri 18-09-15 15:48:00, Vladimir Davydov wrote: > The sane_reclaim() helper is supposed to return false for memcg reclaim > if the legacy hierarchy is used, because the latter lacks dirty > throttling mechanism, and so it did before it was accidentally broken by > commit 33398cf2f360c ("memcg: export struct mem_cgroup"). Fix it. > > Fixes: 33398cf2f360c ("memcg: export struct mem_cgroup") > Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx> Acked-by: Michal Hocko <mhocko@xxxxxxxx> Thanks for catching this up! > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index db5339dd4a32..dbc3b3ae48de 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -175,7 +175,7 @@ static bool sane_reclaim(struct scan_control *sc) > if (!memcg) > return true; > #ifdef CONFIG_CGROUP_WRITEBACK > - if (memcg->css.cgroup) > + if (cgroup_on_dfl(memcg->css.cgroup)) > return true; > #endif > return false; > -- > 2.1.4 -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>