On 15-09-15, 10:04, Steven Rostedt wrote: > On Tue, 15 Sep 2015 14:04:59 +0530 > Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > > index 2614a839c60d..f11e17ad7834 100644 > > --- a/drivers/acpi/ec.c > > +++ b/drivers/acpi/ec.c > > @@ -1237,7 +1237,7 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval) > > /* Use the global lock for all EC transactions? */ > > tmp = 0; > > acpi_evaluate_integer(handle, "_GLK", NULL, &tmp); > > - ec->global_lock = tmp; > > + ec->global_lock = !!tmp; > > BTW, the above is equivalent if global_lock is of type bool. Ah, yes. Thanks for letting me know (I just testedit as well). But will it look sane enough to set a boolean to anything apart from true/false or 1/0? Yes, it will always be set to 0/1 only, but still.. -- viresh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>