2015-09-14 5:09 GMT+03:00 Xishi Qiu <qiuxishi@xxxxxxxxxx>: > Use IS_ALIGNED() to determine whether the shadow span two bytes. > It generates less code and more readable. Add some comments in > shadow check functions. > > Please apply "kasan: fix last shadow judgement in memory_is_poisoned_16()" > first. > > Signed-off-by: Xishi Qiu <qiuxishi@xxxxxxxxxx> > --- > mm/kasan/kasan.c | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c > index 8da2114..00d5605 100644 > --- a/mm/kasan/kasan.c > +++ b/mm/kasan/kasan.c > @@ -86,6 +86,10 @@ static __always_inline bool memory_is_poisoned_2(unsigned long addr) > if (memory_is_poisoned_1(addr + 1)) > return true; > > + /* > + * If the shadow spans two bytes, the first byte should > + * be zero. Hmm.. I found this comment a bit odd. How about this: /* * If single shadow byte covers 2-byte access, * we don't need to do anything more. * Otherwise, test the first shadow byte. */ ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>