On 9/7/15 20:36, Oleg Nesterov wrote: > On 09/05, Chen Gang wrote: >> >> From b12fa5a9263cf4c044988e59f0071f4bcc132215 Mon Sep 17 00:00:00 2001 >> From: Chen Gang <gang.chen.5i5j@xxxxxxxxx> >> Date: Sat, 5 Sep 2015 21:49:56 +0800 >> Subject: [PATCH] mm/mmap.c: Remove useless statement "vma = NULL" in >> find_vma() >> >> Before the main looping, vma is already is NULL, so need not set it to >> NULL, again. >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx> > > Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx> > OK, thanks. I also want to consult: the comments of find_vma() says: "Look up the first VMA which satisfies addr < vm_end, ..." Is it OK? (why not "vm_start <= addr < vm_end"), need we let "vma = tmp" in "if (tmp->vm_start <= addr)"? -- it looks the comments is not match the implementation, precisely (maybe not 1st VMA). Thanks. >> --- >> mm/mmap.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/mm/mmap.c b/mm/mmap.c >> index df6d5f0..4db7cf0 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -2054,7 +2054,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr) >> return vma; >> >> rb_node = mm->mm_rb.rb_node; >> - vma = NULL; >> >> while (rb_node) { >> struct vm_area_struct *tmp; >> -- >> 1.9.3 >> >> > > -- Chen Gang (陈刚) Open, share, and attitude like air, water, and life which God blessed ?韬{.n???檩jg???a?旃???)钋???骅w+h?璀?y/i?⒏??⒎???Щ??m???)钋???痂?^??觥??ザ?v???O璁?f??i?⒏?