Re: [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 26, 2015 at 09:19:48PM +0900, Tetsuo Handa wrote:
> Hello.
> 
> Should selected_tasksize be added to rem even when TIF_MEMDIE was not set?
> 
> Please see a thread from http://www.spinics.net/lists/linux-mm/msg93246.html
> if you want to know why to reverse the order.
> ----------------------------------------
> >From 2d4cc11d8128e4c1397631b91fea78da3eaefb47 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Date: Wed, 26 Aug 2015 20:52:39 +0900
> Subject: [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL.
> 
> If we set TIF_MEMDIE before sending SIGKILL, memory reserves could be
> spent for allocations which are not needed for terminating the victim.
> Reverse the order as with oom_kill_process() does.


I can't take a patch that I have to hand-edit in order to apply it :(

And if we aren't taking patch 1/2, I guess this one isn't needed either?

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]