On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani <toshi.kani@xxxxxx> wrote: > On Wed, 2015-08-26 at 21:34 +0000, Williams, Dan J wrote: [..] >> -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > Should it be better to do: > > #else /* !CONFIG_ARCH_HAS_PMEM_API */ > #define ARCH_MEMREMAP_PMEM MEMREMAP_WT > > so that you can remove all '#ifdef ARCH_MEMREMAP_PMEM' stuff? Yeah, that seems like a nice incremental cleanup for memremap_pmem() to just unconditionally use ARCH_MEMREMAP_PMEM, feel free to send it along. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>