>>> (I hope I'm not annoying you by bikeshedding this too much, although I >>> think this is improving.) >> >> [ I don't mind, although I wish other, more critical parts of the kernel got this >> much attention as well ;-) ] That's the problem with small, understandable problems: people *aren't* scared to mess with them. > It's been fun seeing this evolve, but overall, I tend to agree with > Peter: It's a lot of complexity for little gain. If we're not going to > just kill the Vmalloc* fields (which is probably too controversial) > I'd prefer Linus' simpler version. Are you sure you're not being affected by the number of iterations? The final version is not actually a lot of code (although yes, more than Linus's), and offers the advantage of peace of mind: there's not some nasty-smelling code you can't entirely trust left behind. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>