The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall might make more sense here. Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Christoph Lameter <cl@xxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Mel Gorman <mgorman@xxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxx> Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx> Cc: Minchan Kim <minchan@xxxxxxxxxx> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> Cc: linux-mm@xxxxxxxxx Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- mm/vmstat.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 1fd0886a389f..e6cd18cc4d75 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -12,7 +12,7 @@ #include <linux/fs.h> #include <linux/mm.h> #include <linux/err.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/slab.h> #include <linux/cpu.h> #include <linux/cpumask.h> @@ -1536,7 +1536,7 @@ static int __init setup_vmstat(void) #endif return 0; } -module_init(setup_vmstat) +device_initcall(setup_vmstat) #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_COMPACTION) @@ -1695,6 +1695,5 @@ fail: debugfs_remove_recursive(extfrag_debug_root); return -ENOMEM; } - -module_init(extfrag_debug_init); +device_initcall(extfrag_debug_init); #endif -- 2.5.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>