The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. However one could argue that subsys_initcall might make more sense here. Cc: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: linux-mm@xxxxxxxxx Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- mm/workingset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/workingset.c b/mm/workingset.c index aa017133744b..c2c59f599610 100644 --- a/mm/workingset.c +++ b/mm/workingset.c @@ -8,7 +8,7 @@ #include <linux/writeback.h> #include <linux/pagemap.h> #include <linux/atomic.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/swap.h> #include <linux/fs.h> #include <linux/mm.h> @@ -412,4 +412,4 @@ err_list_lru: err: return ret; } -module_init(workingset_init); +device_initcall(workingset_init); -- 2.5.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>