On Thu, Aug 6, 2015 at 6:59 AM, Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx> wrote: > On (08/06/15 06:20), Dan Streetman wrote: >> > On (08/05/15 09:46), Dan Streetman wrote: >> >> Update the zpool and compressor parameters to be changeable at runtime. >> >> When changed, a new pool is created with the requested zpool/compressor, >> >> and added as the current pool at the front of the pool list. Previous >> >> pools remain in the list only to remove existing compressed pages from. >> >> The old pool(s) are removed once they become empty. >> >> >> > >> > Sorry, just curious, is this functionality/complication really >> > necessary? >> >> Well you could ask the same question about many other module params; >> can't people just configure everything using boot params? ;-) >> >> > How often do you expect people to do that? The way I >> > see it -- a static configuration works just fine: boot, test, >> > re-configure, boot test; compare the results and done. >> >> Sure a static configuration will work (it has since Seth wrote zswap), >> but that doesn't guarantee everyone will want to do it that way. >> Certainly for testing/development/benchmarking avoiding a reboot is >> helpful. And for long-running and/or critical systems that need to >> change their zpool or compressor, for whatever reason, forcing a >> reboot isn't desirable. > > Sorry, I didn't have time to read the patches carefully/attentively > (will do); so my email may be a complete nonsense. > >> Why would someone want to change their compressor or zpool? A simple >> exampe comes to mind - maybe they have 1000's of systems and a bug was >> found in the current level of compressor or zpool - they would then >> have to either reboot all the systems to change to a different >> zpool/compressor, or leave it using the known-buggy one. > > Well, if that buggy compressor is being used by other modules > then rebooting is sort of inevitable. But you still preserve pages > compressed with the old compressor and let user access them, right? > Thus read operation possibly will hit the bug regardless of current > 'front' pool. Yes, currently-compressed pages will be uncompressed using the same compressor. It's only freed once all the pages using it have been removed. > >> In addition, a static boot-time configuration requires adding params >> to the bootloader configuration, *and* rebuilding the initramfs to >> include both the required zpool and compressor. So even for static >> configurations, it's simpler to be able to set the zpool and >> compressor immediately after boot, instead of at boot time. > > I mean, it just feels that this is a way too big change for no particular > use case (no offense). It doesn't take much time to figure out (a simple > google request does the trick here) which one of the available compressors > gives best ratio in general or which one has better read/write > (compress/decompress) speeds. There are hardware compressors now, you know (see PowerPC 842 hw compressor). While a sw compressor won't fail during use (excepting a buggy driver), a hw compressor might fail for who-knows-what-hardware-issue. I suspect there will be more hw compressors in the future. > > A buggy compressor is a good use case, I agree (with the exception that > reboot is still very much possible). But if someone changes compressing > backend because he or she estimates a better compression ratio or > performance then there will be no immediate benefit -- pages compressed > with the old compressor are still there and it will take some unpredictable > amount of time to drain old pools and to remove them. To me, avoiding the need to set boot parameters through the bootloader AND the need to rebuild the initramfs is use case enough to justify this. I can't think of any other driver configuration that *requires* updating the bootloader config and rebuilding the initramfs. > > -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>