Re: [PATCH 1/5] x86, gfp: Cache best near node for memory allocation.

[Tang Chen <tangchen@xxxxxxxxxxxxxx>]

On 08/04/2015 04:26 PM, gongzhaogang@xxxxxxxxxx wrote:

Sorry,I am new.

>But,

>1) in cpu_up(), it will try to online a node, and it doesn't check if

>the node has memory.

>2) in try_offline_node(), it offlines CPUs first, and then the memory.

 

>This behavior looks a little wired, or let's say it is ambiguous. It

>seems that a NUMA node

>consists of CPUs and memory. So if the CPUs are online, the node should

>be online.

I suggested you to try the patch offered by Liu Jiang.

https://lkml.org/lkml/2014/9/11/1087 

Well, I think Liu Jiang meant this patch set. :)

https://lkml.org/lkml/2014/7/11/75

I have tried ,It is OK.

>Unfortunately, since I don't have a machine a with memory-less node, I

>cannot reproduce

>the problem right now.

If  not hurried  , I can test your patches in our environment on weekends.

Thanks. But this version of my patch set is obviously problematic.
It will be very nice of you if you can help to test the next version.
But maybe in a few days.

Thanks. :)