On Fri, Jul 31, 2015 at 05:01:06PM +0200, Jerome Marchand wrote: > On 07/20/2015 04:20 PM, Kirill A. Shutemov wrote: > > @@ -1616,23 +1605,14 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, > > * Note that if it returns 1, this routine returns without unlocking page > > * table locks. So callers must unlock them. > > */ > > The comment above should be updated. Like this? diff --git a/mm/huge_memory.c b/mm/huge_memory.c index d32277463932..78a6c7cdf8f7 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1627,11 +1627,10 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, } /* - * Returns 1 if a given pmd maps a stable (not under splitting) thp. - * Returns -1 if it maps a thp under splitting. Returns 0 otherwise. + * Returns true if a given pmd maps a thp, false otherwise. * - * Note that if it returns 1, this routine returns without unlocking page - * table locks. So callers must unlock them. + * Note that if it returns true, this routine returns without unlocking page + * table lock. So callers must unlock it. */ bool __pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma, spinlock_t **ptl) -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>