On Tue 2015-07-28 13:36:35, Tejun Heo wrote:
> Hello,
>
> On Tue, Jul 28, 2015 at 04:39:24PM +0200, Petr Mladek wrote:
> > -static void khugepaged_wait_work(void)
> > +static void khugepaged_wait_func(struct kthread_work *dummy)
> > {
> > if (khugepaged_has_work()) {
> > if (!khugepaged_scan_sleep_millisecs)
> > - return;
> > + goto out;
> >
> > wait_event_freezable_timeout(khugepaged_wait,
> > - kthread_should_stop(),
> > + !khugepaged_enabled(),
> > msecs_to_jiffies(khugepaged_scan_sleep_millisecs));
> > - return;
> > + goto out;
> > }
> >
> > if (khugepaged_enabled())
> > wait_event_freezable(khugepaged_wait, khugepaged_wait_event());
> > +
> > +out:
> > + if (khugepaged_enabled())
> > + queue_kthread_work(&khugepaged_worker,
> > + &khugepaged_do_scan_work);
> > }
>
> There gotta be a better way to do this. It's outright weird to
> convert it over to work item based interface and then handle idle
> periods by injecting wait work items. If there's an external event
> which wakes up the worker, convert that to a queueing event. If it's
> a timed event, implement a delayed work and queue that with delay.
I am going to give it a try.
Best Regards,
Petr
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>