On 25/07/15 00:21, Julien Grall wrote: > On 24/07/2015 12:47, David Vrabel wrote: >> @@ -550,6 +551,11 @@ int alloc_xenballooned_pages(int nr_pages, struct >> page **pages) >> page = balloon_retrieve(true); >> if (page) { >> pages[pgno++] = page; >> +#ifdef CONFIG_XEN_HAVE_PVMMU >> + ret = xen_alloc_p2m_entry(page_to_pfn(page)); > > Don't you want to call this function only when the guest is not using > auto-translated physmap? xen_alloc_p2m_entry() is a nop in auto-xlate guests, so no need for an additional check here. David -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>