On Wed, Jul 22, 2015 at 10:29:00PM +0800, Baoquan He wrote: > > > So if no reserved_size dyn_size is assigned to zero, and is checked to > > > see if dchunk need be created in below code: > > > > Hmmm... but then pcpu_reserved_chunk is NULL so there still is no > > duplicate on the list, no? > > Yes, you are quite right. I was mistaken. So NACK this patch. But, yeah, it'd be great if we can add a WARN_ON() to ensure that this really doesn't happen along with some comments. Thanks! -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>