On 16/07/15 00:56, David Rientjes wrote: > On Tue, 14 Jul 2015, Vladimir Murzin wrote: > >> - prefer pr_info(... to printk(KERN_INFO ... >> - use %pa for phys_addr_t >> - use cpu_to_be64 while printing pattern in reserve_bad_mem() >> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@xxxxxxx> > > Acked-by: David Rientjes <rientjes@xxxxxxxxxx> > > Not sure why you changed the whitespace in reserve_bad_mem() though. > > I was changed by accident, thanks for pointing it out! Andrew, could you apply the following fixup, please? ---8<--- diff --git a/mm/memtest.c b/mm/memtest.c index 332facd..4b4f36b 100644 --- a/mm/memtest.c +++ b/mm/memtest.c @@ -26,7 +26,7 @@ static u64 patterns[] __initdata = { static void __init reserve_bad_mem(u64 pattern, phys_addr_t start_bad, phys_addr_t end_bad) { - pr_info("%016llx bad mem addr %pa - %pa reserved\n", + pr_info(" %016llx bad mem addr %pa - %pa reserved\n", cpu_to_be64(pattern), &start_bad, &end_bad); memblock_reserve(start_bad, end_bad - start_bad); } --->8--- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href