Re: [PATCH v1 3/4] mm/memory-failure: give up error handling for non-tail-refcounted thp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 16, 2015 at 04:33:07AM +0200, Andi Kleen wrote:
> > @@ -909,6 +909,15 @@ int get_hwpoison_page(struct page *page)
> >  	 * directly for tail pages.
> >  	 */
> >  	if (PageTransHuge(head)) {
> > +		/*
> > +		 * Non anonymous thp exists only in allocation/free time. We
> > +		 * can't handle such a case correctly, so let's give it up.
> > +		 * This should be better than triggering BUG_ON when kernel
> > +		 * tries to touch a "partially handled" page.
> > +		 */
> > +		if (!PageAnon(head))
> > +			return 0;
> 
> Please print a message for this case. In the future there will be
> likely more non anonymous THP pages from Kirill's large page cache work
> (so eventually we'll need it)

OK, I'll do this.

Thanks,
Naoya Horiguchi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]