On Wed, Jul 15, 2015 at 05:19:39PM -0700, David Rientjes wrote: >On Sat, 11 Jul 2015, Wei Yang wrote: > >> Each memblock_region has flags to indicates the Node ID of this range. For >> the overlap case, memblock_add_range() inserts the lower part and leave the >> upper part as indicated in the overlapped region. >> > >Memblock region flags do not specify node ids, so this is somewhat >misleading. > Thanks for pointing out, the commit message is not correct. It should be "type" instead of "Node ID". >> If the flags of the new range differs from the overlapped region, the >> information recorded is not correct. >> >> This patch adds a WARN_ON when the flags of the new range differs from the >> overlapped region. >> >> Signed-off-by: Wei Yang <weiyang@xxxxxxxxxxxxxxxxxx> >> --- >> mm/memblock.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/mm/memblock.c b/mm/memblock.c >> index 95ce68c..bde61e8 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -569,6 +569,7 @@ repeat: >> #ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP >> WARN_ON(nid != memblock_get_region_node(rgn)); >> #endif >> + WARN_ON(flags != rgn->flags); >> nr_new++; >> if (insert) >> memblock_insert_region(type, i++, base, -- Richard Yang Help you, Help me -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>