Re: [PATCH 0/2] mm/shrinker: make unregister_shrinker() less fragile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 13, 2015 at 06:34:42PM +0900, Sergey Senozhatsky wrote:
> Yes. 'Nice' used in a sense that drivers have logic to release the
> memory anyway; mm asks volunteers (the drivers that have registered
> shrinker callbacks) to release some spare/wasted/etc. when things
> are getting tough (the drivers are not aware of that in general).
> This is surely important to mm, not to the driver though -- it just
> agrees to be 'nice', but even not expected to release any memory at
> all (IOW, this is not a contract).

Not registering the shrinker is a plain and simple memory leak.  Just
like a missing free your driver will appear to work fine for a while,
but eventually the leaks will bring down the whole system including
your driver.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]