Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx> writes: > +static int insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, > + pmd_t *pmd, unsigned long pfn, pgprot_t prot, bool write) > +{ > + struct mm_struct *mm = vma->vm_mm; > + pmd_t entry; > + spinlock_t *ptl; > + > + ptl = pmd_lock(mm, pmd); > + if (pmd_none(*pmd)) { > + entry = pmd_mkhuge(pfn_pmd(pfn, prot)); > + if (write) { > + entry = pmd_mkyoung(pmd_mkdirty(entry)); > + entry = maybe_pmd_mkwrite(entry, vma); > + } > + set_pmd_at(mm, addr, pmd, entry); > + update_mmu_cache_pmd(vma, addr, pmd); > + } > + spin_unlock(ptl); > + return VM_FAULT_NOPAGE; > +} What's the point of the return value? Cheers, Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>