On Thu, Jul 02, 2015 at 12:08:36PM -0400, nick wrote: > I looked into that patch further and would were correct it was wrong. > However here is a bug fix for the drm driver code that somebody else > stated was right but haven gotten a reply to from the maintainer and > have tried resending. Hi Nick, Don't bother sending more low-value patches like this; they don't impress me. Send me a patch that fixes a deep bug, where you can demonstrate that you understand the underlying design of the code, can point out a flaw, and then explain why your patch is an improvement, and documents how you tested it. Or do something beyond changing return values or return types, and optimize some performance-critical part of the kernel, and in the commit description, explain why it improves things, how you measured the performance improvement, and why this is applicable in a real-life situation. Even a broken clock can be right twice a day, and the fact that it is possible that you can author a correct patch isn't all that impressive. You need to understand deep understanding of the code you are modifying, and or else it's not worth my time to go through a large number of low-value patches that don't really improve the code base much, when the risk that you have accidentally introduced a bug is high given that (a) you've demonstrated an inability to explain some of your patches, and (b) in many cases, you have no fear about sending patches that you can't personally test. These two shortcomings in combination are fatal. If you can demonstrate that you can become a thoughtful and careful coder, I would be most pleased to argue to Greg K-H that you have turned over a new leaf. To date, however, you have not demonstrated any of the above, and you've made me regret that I've tried to waste time looking at your patches that you've sent me in the hopes of convincing me that you've really changed --- when it's clear you haven't. I do hope that, one day, you will be able to be a good coder. But that day is clearly not today. Best regards, - Ted -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>