On Mon 29-06-15 11:23:08, Nicholas Krause wrote: [...] > I agree with and looked into the callers about this wasn't sure if you > you wanted me to return - ENOMEM. I will rewrite this patch the other > way. I am not sure this path really needs a cleanup. > Furthermore I apologize about this and do have actual useful > patches but will my rep it's hard to get replies from maintainers. You can hardly expect somebody will be thrilled about your patches when their fault rate is close to 100%. Reviewing each patch takes time and that is a scarce resource. If you want people to follow your patches make sure you are offering something that might be interesting or useful. Cleanups like these usually are not interesting without either building something bigger on top of them or when they improve readability considerably. [...] -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>