Re: [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in mempool_destroy()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 9 Jun 2015, Sergey Senozhatsky wrote:

> mempool_destroy() does not tolerate a NULL mempool_t pointer
> argument and performs a NULL-pointer dereference. This requires
> additional attention and effort from developers/reviewers and
> forces all mempool_destroy() callers to do a NULL check
> 
> 	if (pool)
> 		mempool_destroy(pool);
> 
> Or, otherwise, be invalid mempool_destroy() users.
> 
> Tweak mempool_destroy() and NULL-check the pointer there.
> 
> Proposed by Andrew Morton.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> Reported-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> LKML-reference: https://lkml.org/lkml/2015/6/8/583

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

I like how your patch series is enabling us to remove many lines from the 
source code.  But doing s/Reported-by/Suggested-by/ can also make your 
changelog two lines shorter ;)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]