On Tue, 9 Jun 2015 21:04:48 +0900 Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> wrote: > The existing pools' destroy() functions do not allow NULL pool pointers; > instead, every destructor() caller forced to check if pool is not NULL, > which: > a) requires additional attention from developers/reviewers > b) may lead to a NULL pointer dereferences if (a) didn't work > > > First 3 patches tweak > - kmem_cache_destroy() > - mempool_destroy() > - dma_pool_destroy() > > to handle NULL pointers. Well I like it, even though it's going to cause a zillion little cleanup patches. checkpatch already has a "kfree(NULL) is safe and this check is probably not required" test so I guess Joe will need to get busy ;) I'll park these patches until after 4.1 is released - it's getting to that time... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>