Re: [next:master 7235/7555] mm/page_alloc.c:654:121: warning: comparison of distinct pointer types lacks a cast

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 31 May 2015 12:18:15 +0200 Dominik Dingel <dingel@xxxxxxxxxxxxxxxxxx> wrote:

> > And on s390, HPAGE_SHIFT is unsigned int.  On x86 HPAGE_SHIFT has type
> > int.  I suggest the fix here is to make s390's HPAGE_SHIFT have type
> > int as well.
> 
> Thanks for noticing. As my way to handle this was mostly inspired by the
> way powerpc does it,  I'm kind of puzzled why they don't have the same problem?
> 
> So I checked and your fix seems to be the right thing to do. But then I would
> assume the powerpc type for HPAGE should also be changed?

powerpc sets CONFIG_HUGETLB_PAGE_SIZE_VARIABLE so it uses

extern int pageblock_order;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]